This repository was archived by the owner on May 20, 2026. It is now read-only.
Fix skillContentRead and readFileToolInvoked telemetry in readFileTool#5051
Closed
AbhitejJohn wants to merge 1 commit into
Closed
Fix skillContentRead and readFileToolInvoked telemetry in readFileTool#5051AbhitejJohn wants to merge 1 commit into
AbhitejJohn wants to merge 1 commit into
Conversation
Fixes skillContentRead telemetry to ensure each field has a proper prefix. Also fixed readFileToolInvoked telemetry properties to use explicit key-value pairs instead of shorthand. Both events validated in local telemetry.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts telemetry payload construction in the read_file tool to avoid shorthand object properties and ensure all telemetry fields are explicitly keyed, improving consistency/reliability of emitted event properties.
Changes:
- Update
readFileToolInvokedMSFT telemetry properties to use explicitkey: valuepairs. - Update
skillContentReadGH/enhanced/internal telemetry properties to use explicitkey: valuepairs and consistently referenceplaintextPropsforcontentHash.
Show a summary per file
| File | Description |
|---|---|
| src/extension/tools/node/readFileTool.tsx | Makes telemetry event property objects explicit (no shorthand), aligning emitted keys with intended schema. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Author
|
ok, this isn't really required. The reason I wasn't seeing this earlier is because in Dev mode certain events weren't really flushed. Guided by Copilot, I made a local change to add a condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
skillContentReadtelemetry to ensure each field has a proper prefix instead of using shorthand properties.\n\nAlso fixedreadFileToolInvokedtelemetry properties to use explicit key-value pairs instead of shorthand. Both events validated in local telemetry.